From 753827ef333cf1d4f08b017f197cc4337e980fd6 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 3 Nov 2022 23:05:03 +0100 Subject: soc/amd/picasso/acpi: include pci_int_defs.asl from soc.asl Instead of including pci_int_defs.asl in each board's DSDT, include it in the common soc.asl. This moves the PRQM OperationRegion and the PRQI IndexField defined in pci_int_defs.asl into the \_SB scope, but those are defined inside the \_SB scope both in the Picasso reference code and for the AMD SoCs from Cezanne on. TEST=Both Linux and Windows still boot and don't show ACPI errors on Mandolin after moving this inside the \_SB scope Signed-off-by: Felix Held Change-Id: Ib4e7bfb15de184cc43cd17c8249be0f59405793f Reviewed-on: https://review.coreboot.org/c/coreboot/+/69188 Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger Reviewed-by: Matt DeVillier Reviewed-by: Jason Glenesk --- src/mainboard/amd/bilby/dsdt.asl | 3 --- src/mainboard/amd/mandolin/dsdt.asl | 3 --- 2 files changed, 6 deletions(-) (limited to 'src/mainboard/amd') diff --git a/src/mainboard/amd/bilby/dsdt.asl b/src/mainboard/amd/bilby/dsdt.asl index 140f3950e0..dd42608162 100644 --- a/src/mainboard/amd/bilby/dsdt.asl +++ b/src/mainboard/amd/bilby/dsdt.asl @@ -16,9 +16,6 @@ DefinitionBlock ( #include #include - /* PCI IRQ mapping for the Southbridge */ - #include - /* Power state notification to ALIB */ #include diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 140f3950e0..dd42608162 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -16,9 +16,6 @@ DefinitionBlock ( #include #include - /* PCI IRQ mapping for the Southbridge */ - #include - /* Power state notification to ALIB */ #include -- cgit v1.2.3