From b0ae42b5bb7fe7c9f6e8301bff8fbabe95294c62 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 23 Jun 2020 02:50:00 +0300 Subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use the pre-defined constant address directly. Change-Id: I29fbc82fffc69b864adb4ddbda1425db98e2e48a Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/42708 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Furquan Shaikh --- src/mainboard/amd/union_station/BiosCallOuts.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'src/mainboard/amd/union_station') diff --git a/src/mainboard/amd/union_station/BiosCallOuts.c b/src/mainboard/amd/union_station/BiosCallOuts.c index a5634ecfd0..deb6176faf 100644 --- a/src/mainboard/amd/union_station/BiosCallOuts.c +++ b/src/mainboard/amd/union_station/BiosCallOuts.c @@ -30,7 +30,6 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigP AGESA_STATUS Status; UINTN FcnData; MEM_DATA_STRUCT *MemData; - UINT32 AcpiMmioAddr; UINT32 GpioMmioAddr; UINT8 Data8; UINT8 TempData8; @@ -39,8 +38,7 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigP MemData = ConfigPtr; Status = AGESA_SUCCESS; - AcpiMmioAddr = AMD_SB_ACPI_MMIO_ADDR; - GpioMmioAddr = AcpiMmioAddr + GPIO_BASE; + GpioMmioAddr = ACPIMMIO_GPIO_BASE_100; Data8 = Read64Mem8(GpioMmioAddr+SB_GPIO_REG178); Data8 &= ~BIT5; @@ -106,13 +104,12 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *Confi UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo; UINT32 GpioMmioAddr; - UINT32 AcpiMmioAddr; UINT8 Data8; + GpioMmioAddr = ACPIMMIO_GPIO_BASE_100; + FcnData = Data; ResetInfo = ConfigPtr; - AcpiMmioAddr = AMD_SB_ACPI_MMIO_ADDR; - GpioMmioAddr = AcpiMmioAddr + GPIO_BASE; Status = AGESA_UNSUPPORTED; switch (ResetInfo->ResetId) { case 4: -- cgit v1.2.3