From 5c2025c40f747c383e6106799f06c4a92cd07201 Mon Sep 17 00:00:00 2001 From: Bruce Griffith Date: Tue, 23 Apr 2013 14:31:55 -0600 Subject: AMD Hudson A55E: Remove GEC firmware blob kconfig prompt The "gigabit ethernet controller" (GEC) block was added to AMD Hudson A55E to integrate ethernet capabilities into an AMD southbridge. The GEC is designed to work with B50610 and B50610M gigabit PHY chips from Broadcom. These parts may not be generally available in small quantities for embedded development. The GEC block requires an opaque firmware blob to function. The GEC blob is controlled by AMD and Broadcom and is not available from coreboot.org. This change removes GEC support from AMD Parmer and AMD Thatcher mainboards since these boards do not have the Broadcom PHY. AMD has requested that the GEC be hidden for Hudson FCH since the PHY parts are not generally available. This Kconfig option can make it appear that this is a viable and supported way to add Ethernet to an embedded board. It is possible to use the Hudson GEC block with other PHYs, but this requires development of a custom GEC blob and a custom Ethernet driver. A custom GEC blob has been developed for a Micrel PHY, but there is no accompanying driver. Change-Id: I7a7bf4d41e453390ecf987c9c45ef2434fc1f1a3 Signed-off-by: Bruce Griffith Reviewed-on: http://review.coreboot.org/3127 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Jens Rottmann Reviewed-by: Martin Roth --- src/mainboard/amd/parmer/agesawrapper.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/mainboard/amd/parmer/agesawrapper.c') diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c index aecd1eaa69..a81a997003 100644 --- a/src/mainboard/amd/parmer/agesawrapper.c +++ b/src/mainboard/amd/parmer/agesawrapper.c @@ -557,7 +557,6 @@ STATIC VOID s3_resume_init_data(FCH_DATA_BLOCK *FchParams) FchParams->Sata.SataRaidSsid = UserOptions.FchBldCfg->CfgSataRaidSsid; FchParams->Sata.SataAhciSsid = UserOptions.FchBldCfg->CfgSataAhciSsid; FchParams->Sata.SataIdeSsid = UserOptions.FchBldCfg->CfgSataIdeSsid; - FchParams->Gec.GecShadowRomBase = UserOptions.FchBldCfg->CfgGecShadowRomBase; FchParams->Spi.RomBaseAddress = UserOptions.FchBldCfg->CfgSpiRomBaseAddress; FchParams->Sd.SdSsid = UserOptions.FchBldCfg->CfgSdSsid; FchParams->Spi.LpcSsid = UserOptions.FchBldCfg->CfgLpcSsid; -- cgit v1.2.3