From 53584fa32f18eafa1f71be511f20d388550b918b Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 15 Jul 2014 14:38:51 +0300 Subject: AMD get_bus_conf(): Drop bus_type array MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only ever used as lvalue, so no point creating the array. Change-Id: I6699dfae9377a895e9bc4a52579d00ddcfa60a9f Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/6277 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Rudolf Marek --- src/mainboard/amd/olivehill/get_bus_conf.c | 12 +----------- src/mainboard/amd/olivehill/mptable.c | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) (limited to 'src/mainboard/amd/olivehill') diff --git a/src/mainboard/amd/olivehill/get_bus_conf.c b/src/mainboard/amd/olivehill/get_bus_conf.c index f1643a43a7..3aeeb90d8c 100644 --- a/src/mainboard/amd/olivehill/get_bus_conf.c +++ b/src/mainboard/amd/olivehill/get_bus_conf.c @@ -45,7 +45,6 @@ u32 pci1234x[] = { 0x0000ff0, }; -u32 bus_type[256]; u32 sbdn_yangtze; @@ -55,7 +54,7 @@ void get_bus_conf(void) u32 value; device_t dev; - int i, j; + int i; dev = dev_find_slot(0, PCI_DEVFN(0, 0)); /* clear IoapicSbFeatureEn */ @@ -72,11 +71,6 @@ void get_bus_conf(void) memset(bus_yangtze, 0, sizeof(bus_yangtze)); - for (i = 0; i < 256; i++) { - bus_type[i] = 0; /* default ISA bus. */ - } - - bus_type[0] = 1; /* pci */ // bus_yangtze[0] = (sysconf.pci1234[0] >> 16) & 0xff; bus_yangtze[0] = (pci1234x[0] >> 16) & 0xff; @@ -89,8 +83,6 @@ void get_bus_conf(void) bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); bus_isa++; - for (j = bus_yangtze[1]; j < bus_isa; j++) - bus_type[j] = 1; } for (i = 0; i < 4; i++) { @@ -101,8 +93,6 @@ void get_bus_conf(void) bus_isa++; } } - for (j = bus_yangtze[2]; j < bus_isa; j++) - bus_type[j] = 1; /* I/O APICs: APIC ID Version State Address */ bus_isa = 10; diff --git a/src/mainboard/amd/olivehill/mptable.c b/src/mainboard/amd/olivehill/mptable.c index 3ccb9100c9..79750e9f6b 100644 --- a/src/mainboard/amd/olivehill/mptable.c +++ b/src/mainboard/amd/olivehill/mptable.c @@ -31,7 +31,6 @@ #define IO_APIC_ID CONFIG_MAX_CPUS extern u8 bus_yangtze[6]; -extern u32 bus_type[256]; extern u32 sbdn_yangtze; extern u32 apicid_yangtze; -- cgit v1.2.3