From 8052fe459c777db7985bdfed3ca198a556fc970c Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Thu, 3 Jan 2019 11:38:43 +0200 Subject: amdfam10 boards: Drop const variables sbdn_sb800 and sbdn_sb700 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They evaluate to const zero and obscure PCI_DEVFN() use. Change-Id: I8bd8dced62094d5ee8e957241ac29ead054f5c05 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30632 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans Reviewed-by: Angel Pons --- src/mainboard/amd/bimini_fam10/get_bus_conf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/mainboard/amd/bimini_fam10/get_bus_conf.c') diff --git a/src/mainboard/amd/bimini_fam10/get_bus_conf.c b/src/mainboard/amd/bimini_fam10/get_bus_conf.c index 5359c0e249..3c9b2f50ee 100644 --- a/src/mainboard/amd/bimini_fam10/get_bus_conf.c +++ b/src/mainboard/amd/bimini_fam10/get_bus_conf.c @@ -46,7 +46,6 @@ u32 hcdnx[] = { static u32 sbdn_rs780; -u32 sbdn_sb800; void get_bus_conf(void) { @@ -64,7 +63,6 @@ void get_bus_conf(void) sysconf.sbdn = (sysconf.hcdn[0] & 0xff); sbdn_rs780 = sysconf.sbdn; - sbdn_sb800 = 0; memset(bus_sb800, 0, sizeof(bus_sb800)); @@ -77,13 +75,13 @@ void get_bus_conf(void) bus_sb800[0] = bus_rs780[0]; /* sb800 */ - dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(sbdn_sb800 + 0x14, 4)); + dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(0x14, 4)); if (dev) { bus_sb800[1] = pci_read_config8(dev, PCI_SECONDARY_BUS); } for (i = 0; i < 4; i++) { - dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(sbdn_sb800 + 0x15, i)); + dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(0x15, i)); if (dev) { bus_sb800[2 + i] = pci_read_config8(dev, PCI_SECONDARY_BUS); } -- cgit v1.2.3