From 5f9c6734fc9bbe69c007c46c8ec6f314bd5522a8 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Wed, 28 Jun 2017 16:42:51 +0200 Subject: lib/spd_bin: Use proper I2C addresses Use the plain address instead of the weird shifted encoding (e.g. if we'd use `0xa0` as address, it's actually `0x50` encoded into a write command). Change-Id: I6febb2e04e1c6de4294dfa37bde16b147a80b7a8 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/20405 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh --- src/lib/spd_bin.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/lib') diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index a9f6a36045..b5ab9b7db1 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -128,8 +128,6 @@ int get_spd_cbfs_rdev(struct region_device *spd_rdev, u8 spd_index) static void get_spd(u8 *spd, u8 addr) { u16 i; - /* Assuming addr is 8 bit address, make it 7 bit */ - addr = addr >> 1; if (smbus_read_byte(0, addr, 0) == 0xff) { printk(BIOS_INFO, "No memory dimm at address %02X\n", addr << 1); -- cgit v1.2.3