From 63b53561e1f651f3ca71b925fda4a9567d4a4256 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Sat, 7 Mar 2020 19:20:49 +0100 Subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Building libgfxinit with Debian’s toolchain – latest test with *gnat-11* 11.2.0-13 from Debian sid/unstable – the build fails with the error below. E: Invalid reloc type: 10 E: Unable to create rmodule from 'build/cbfs/fallback/ramstage.debug'. Debian’s toolchain is built without enabling PIE by default. So, explicitly pass `-fno-pie` to `ADAFLAGS_common` to be independent from how the toolchain was built. TEST=*gnat* 11.2.0-13 successfully. builds purism/librem_cnl/variants/librem_mini with libgfxint. With the coreboot toolchain `make BUILD_TIMELESS=1` produces the same `build/coreboot.rom` for `BOARD_PURISM_LIBREM_MINI_V2=y` on top of commit 50251400d2 (sb/intel/common/firmware: Reword me_cleaner warning) with and without the change. Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/c/coreboot/+/43759 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/lib/gnat/Makefile.inc | 1 + 1 file changed, 1 insertion(+) (limited to 'src/lib/gnat/Makefile.inc') diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index e7405648d6..065ba71404 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -13,6 +13,7 @@ ADAFLAGS_libgnat-$(1) := \ -I$$(src)/lib/gnat/ \ $$(GCC_ADAFLAGS_$(1)) \ -Werror \ + -fno-pie \ libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads -- cgit v1.2.3