From 35af5c47b030c0a1837cb34bc9ae4d50734fefb0 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Thu, 9 Mar 2017 17:35:28 -0800 Subject: src/lib: Fix spacing Fix the following errors and warnings detected by checkpatch.pl: ERROR: spaces required around that '?' (ctx:WxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '+=' (ctx:VxV) ERROR: space required after that ',' (ctx:VxV) ERROR: space required before the open brace '{' ERROR: space required after that close brace '}' ERROR: need consistent spacing around '+' (ctx:WxV) ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '&' (ctx:VxW) ERROR: spaces required around that '?' (ctx:VxW) ERROR: spaces required around that ':' (ctx:VxW) ERROR: trailing whitespace ERROR: space prohibited before that '++' (ctx:WxO) ERROR: space prohibited before that ',' (ctx:WxW) ERROR: space prohibited after that '!' (ctx:BxW) ERROR: spaces prohibited around that '->' (ctx:VxW) ERROR: space prohibited after that '-' (ctx:WxW) WARNING: space prohibited before semicolon WARNING: unnecessary whitespace before a quoted newline WARNING: missing space after return type Note that lib/libgcov.c and lib/lzmadecode.c are providing false positives for ERROR: need consistent spacing around '*' (ctx:WxV) An example is: void __gcov_merge_add(gcov_type *counters __attribute__ ((unused)), unsigned int n_counters __attribute__ ((unused))) {} TEST=Build and run on Galileo Gen2 Change-Id: I0016327a5754018eaeb25bedf42338291632c7c1 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18733 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/lib/gcov-io.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/lib/gcov-io.h') diff --git a/src/lib/gcov-io.h b/src/lib/gcov-io.h index 89cbe49e7c..6644e27474 100644 --- a/src/lib/gcov-io.h +++ b/src/lib/gcov-io.h @@ -300,7 +300,7 @@ typedef HOST_WIDEST_INT gcov_type; #include "gcov-iov.h" /* Convert a magic or version number to a 4 character string. */ -#define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ +#define GCOV_UNSIGNED2STRING(ARRAY, VALUE) \ ((ARRAY)[0] = (char)((VALUE) >> 24), \ (ARRAY)[1] = (char)((VALUE) >> 16), \ (ARRAY)[2] = (char)((VALUE) >> 8), \ @@ -387,12 +387,12 @@ typedef HOST_WIDEST_INT gcov_type; #define GCOV_TAG_MASK(TAG) (((TAG) - 1) ^ (TAG)) /* Return nonzero if SUB is an immediate subtag of TAG. */ -#define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ +#define GCOV_TAG_IS_SUBTAG(TAG, SUB) \ (GCOV_TAG_MASK(TAG) >> 8 == GCOV_TAG_MASK(SUB) \ && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK(TAG))) /* Return nonzero if SUB is at a sublevel to TAG. */ -#define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ +#define GCOV_TAG_IS_SUBLEVEL(TAG, SUB) \ (GCOV_TAG_MASK(TAG) > GCOV_TAG_MASK(SUB)) /* Basic block flags. */ -- cgit v1.2.3