From cc335c756720ad8ba345e593a028761394443972 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 2 Oct 2018 11:58:28 +0200 Subject: src/lib/edid.c: Replace #if 1 with something useful Since `#if 1` is rather useless, and the code inside it is just several `printk(BIOS_SPEW)`, using `if (console_log_level(BIOS_SPEW))` instead seems more reasonable. Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/28872 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/lib/edid.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/lib/edid.c') diff --git a/src/lib/edid.c b/src/lib/edid.c index 9cf9b8a1ed..37939eb081 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -204,12 +204,13 @@ detailed_block(struct edid *result_edid, unsigned char *x, int in_extension, { struct edid *out = &tmp_edid; int i; -#if 1 - printk(BIOS_SPEW, "Hex of detail: "); - for (i = 0; i < 18; i++) - printk(BIOS_SPEW, "%02x", x[i]); - printk(BIOS_SPEW, "\n"); -#endif + + if (console_log_level(BIOS_SPEW)) { + printk(BIOS_SPEW, "Hex of detail: "); + for (i = 0; i < 18; i++) + printk(BIOS_SPEW, "%02x", x[i]); + printk(BIOS_SPEW, "\n"); + } /* Result might already have some valid fields like mode_is_supported */ *out = *result_edid; -- cgit v1.2.3