From c80ff8437d61f0867eccc520cc68d19fe181af14 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Mon, 17 Sep 2018 16:19:34 -0600 Subject: ec/google/chromeec: Update google_chromeec_get_board_version prototype The helper function to get the board version from EC returns 0 on failure. But 0 is also a valid board version. Update the helper function to return -1 on failure and update the use-cases. BUG=b:114001972,b:114677884,b:114677887 Change-Id: I93e8dbce2ff26e76504b132055985f53cbf07d31 Signed-off-by: Karthikeyan Ramasubramanian Tested-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/28576 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Jett Rink --- src/include/boardid.h | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/include') diff --git a/src/include/boardid.h b/src/include/boardid.h index e1bce0388a..a959b85367 100644 --- a/src/include/boardid.h +++ b/src/include/boardid.h @@ -20,6 +20,15 @@ #define UNDEFINED_STRAPPING_ID (~0) +#define BOARD_ID_UNKNOWN ~((uint32_t)0) /* unsigned equivalent to -1 */ +#define BOARD_ID_INIT ~((uint32_t)1) /* unsigned equivalent to -2 */ +/** + * board_id() - Get the board version + * + * Return: board version on success, BOARD_ID_UNKNOWN on failure/error. + * + * This function is used to get the mainboard version. + */ uint32_t board_id(void); /* differentiates revisions */ uint32_t ram_code(void); /* identifies installed DRAM modules */ uint32_t sku_id(void); /* differentiates other optional components */ -- cgit v1.2.3