From b759a4f987fe284150334cae184801e2be1f9c53 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Fri, 25 Oct 2019 18:06:58 +0200 Subject: cbmem.h: Align comment with the reality of implementations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cbmem_top() should simply not be called before memory is initialed, in order for the implementation to return something meaningful. Change-Id: I8fe32844af290626a0f91279143fda4d3442680f Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/36334 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Michael Niewöhner --- src/include/cbmem.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/include') diff --git a/src/include/cbmem.h b/src/include/cbmem.h index f972ba6503..4005fa205a 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -71,9 +71,8 @@ void cbmem_top_init(void); /* Return the top address for dynamic cbmem. The address returned needs to * be consistent across romstage and ramstage, and it is required to be * below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no - * upper limit. - * x86 boards or chipsets must return NULL before the cbmem backing store has - * been initialized. */ + * upper limit. This should not be called before memory is initialized. + */ void *cbmem_top(void); /* Add a cbmem entry of a given size and id. These return NULL on failure. The -- cgit v1.2.3