From 9620b3d152e0c939d06b900aa65dba3f26ebe2e2 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Fri, 23 Feb 2024 10:28:08 +0900 Subject: include/device/azalia_device.h: Correct location2 shift to 28 bits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The location is specified to be in range of 29:24, which is further divided into upper bits (location2) [5:4] and lower bits (location1) [3:0]. This also corrects the resulting values of clevo/l140mu. References: - Intel High Definition Audio Specification, rev. 1.0a, page 178, Figure 74. Configuration Data Structure. TEST=Timeless build using AZALIA_PIN_DESC() and without now produce the same binary. Change-Id: Ia5a3431b70783cb88e866d0fd8ea5530100f3d52 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/80727 Reviewed-by: Felix Singer Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/include/device/azalia_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/include') diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index f7c1448863..42807fdd46 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -120,7 +120,7 @@ enum azalia_pin_misc { #define AZALIA_PIN_DESC(conn, location2, location1, dev, type, color, misc, \ association, sequence) \ (((conn) << 30) | \ - ((location2) << 27) | \ + ((location2) << 28) | \ ((location1) << 24) | \ ((dev) << 20) | \ ((type) << 16) | \ -- cgit v1.2.3