From 66c6413c69abb7335efc4ea07f4c811c042704b6 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 19 Dec 2020 16:19:44 +0200 Subject: ACPI: Refactor ChromeOS specific ACPI GNVS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The layout of GNVS has expectation for a fixed size array for chromeos_acpi_t. This allows us to reduce the exposure of . If chromeos_acpi_t was the last entry in struct global_nvs padding at the end is also removed. If device_nvs_t exists, place a properly sized reserve for chromeos_acpi_t in the middle. Allocation from cbmem is adjusted such that it matches exactly the OperationRegion size defined inside the ASL. Change-Id: If234075e11335ce958ce136dd3fe162f7e5afdf7 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/48788 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/include/acpi/acpi_gnvs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/include') diff --git a/src/include/acpi/acpi_gnvs.h b/src/include/acpi/acpi_gnvs.h index b35874d4e9..c0e8aed526 100644 --- a/src/include/acpi/acpi_gnvs.h +++ b/src/include/acpi/acpi_gnvs.h @@ -8,14 +8,13 @@ void *acpi_get_gnvs(void); void *gnvs_get_or_create(void); -void gnvs_assign_chromeos(void); +void gnvs_assign_chromeos(void *gnvs_section); void gnvs_set_ecfw_rw(void); /* Platform code must implement these. */ struct global_nvs; size_t gnvs_size_of_array(void); uint32_t *gnvs_cbmc_ptr(struct global_nvs *gnvs); -void *gnvs_chromeos_ptr(struct global_nvs *gnvs); /* * These functions populate the gnvs structure in acpi table. -- cgit v1.2.3