From 5a1f9a87cb2f6a3e0699f3d13db41c7da2963b88 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Thu, 7 Sep 2017 21:17:33 -0600 Subject: cpu/x86/mp_init: remove adjust_cpu_apic_entry() The original purpose of adjust_cpu_apic_entry() was to set up an APIC map. That map was effectively only used for mapping *default* APIC id to CPU number in the SMM handler. The normal AP startup path didn't need this mapping because it was whoever won the race got the next cpu number. Instead of statically calculating (and wrong) just initialize the default APIC id map when the APs come online. Once the APs are online the SMM handler is loaded and the mapping is utilized. Change-Id: Idff3b8cfc17aef0729d3193b4499116a013b7930 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/21452 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Subrata Banik Reviewed-by: Marshall Dawson --- src/include/cpu/x86/mp.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/include') diff --git a/src/include/cpu/x86/mp.h b/src/include/cpu/x86/mp.h index 0671b62551..f6afc84f35 100644 --- a/src/include/cpu/x86/mp.h +++ b/src/include/cpu/x86/mp.h @@ -57,14 +57,6 @@ struct mp_ops { * can load the microcode in parallel. */ void (*get_microcode_info)(const void **microcode, int *parallel); - /* - * Optionally provide a function which adjusts the APIC id - * map to CPU number. By default the CPU number and APIC id - * are 1:1. To change the APIC id for a given CPU return the - * new APIC id. It's called for each CPU as indicated by - * get_cpu_count(). - */ - int (*adjust_cpu_apic_entry)(int cpu, int cur_apic_id); /* * Optionally adjust SMM handler parameters to override the default * values. The is_perm variable indicates if the parameters to adjust -- cgit v1.2.3