From b2893a0169ce603926bf13465432a15c4526de97 Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Tue, 23 Apr 2013 10:59:11 -0700 Subject: Provide support for setting up the framebuffer from EDID Add three functions to edid.c: void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr) takes an edid and uintptr_t, and fills in a static lb_framebuffer struct as well as setting the static vbe_valid to 1 unless some problem is found in the edid. The intent here is that this could be called from the native graphics setup code on both ARM and x86. int vbe_mode_info_valid(void) returns value of the static vbe_valid. void fill_lb_framebuffer(struct lb_framebuffer *framebuffer) copies the static edid_fb to lb_framebuffer. There is now a common vbe.h in src/include, removed the two special ones. In general, graphics in coreboot is a mess, but graphics is always a mess. We don't have a clean way to try two different ways to turn on a device and use the one that works. One battle at a time. Overall, things are much better. The best part: this code would also work for ARM, which also uses EDID. Change-Id: Id23eb61498b331d44ab064b8fb4cb10f07cff7f3 Signed-off-by: Ronald G. Minnich Signed-off-by: Gabe Black Reviewed-on: http://review.coreboot.org/3636 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/include/edid.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/include/edid.h') diff --git a/src/include/edid.h b/src/include/edid.h index 6d76bb7efb..8809cced36 100644 --- a/src/include/edid.h +++ b/src/include/edid.h @@ -36,6 +36,8 @@ struct edid { unsigned int nonconformant; unsigned int type; unsigned int bpp; + unsigned int xres; + unsigned int yres; unsigned int voltage; unsigned int sync; unsigned int xsize_cm; @@ -62,5 +64,7 @@ struct edid { const char *stereo; }; +/* Defined in src/lib/edid.c */ int decode_edid(unsigned char *edid, int size, struct edid *out); + #endif /* EDID_H */ -- cgit v1.2.3