From 5517246a0d254b3628ee435ac00b47eaefa569f6 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Thu, 7 Mar 2019 11:13:29 +0200 Subject: device/pci_ops: Unify signatures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use fixed width types and const pointers for dev. Change-Id: Ide3b70238479ad3e1869ed22aa4fa0f1ff8aa766 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/31845 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/include/device/pci_mmio_cfg.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) (limited to 'src/include/device/pci_mmio_cfg.h') diff --git a/src/include/device/pci_mmio_cfg.h b/src/include/device/pci_mmio_cfg.h index aaa21813ce..64406a728e 100644 --- a/src/include/device/pci_mmio_cfg.h +++ b/src/include/device/pci_mmio_cfg.h @@ -22,7 +22,7 @@ static __always_inline -u8 pci_mmio_read_config8(pci_devfn_t dev, unsigned int where) +uint8_t pci_mmio_read_config8(pci_devfn_t dev, uint16_t where) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | where); @@ -30,7 +30,7 @@ u8 pci_mmio_read_config8(pci_devfn_t dev, unsigned int where) } static __always_inline -u16 pci_mmio_read_config16(pci_devfn_t dev, unsigned int where) +uint16_t pci_mmio_read_config16(pci_devfn_t dev, uint16_t where) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | (where & ~1)); @@ -38,7 +38,7 @@ u16 pci_mmio_read_config16(pci_devfn_t dev, unsigned int where) } static __always_inline -u32 pci_mmio_read_config32(pci_devfn_t dev, unsigned int where) +uint32_t pci_mmio_read_config32(pci_devfn_t dev, uint16_t where) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | (where & ~3)); @@ -46,7 +46,7 @@ u32 pci_mmio_read_config32(pci_devfn_t dev, unsigned int where) } static __always_inline -void pci_mmio_write_config8(pci_devfn_t dev, unsigned int where, u8 value) +void pci_mmio_write_config8(pci_devfn_t dev, uint16_t where, uint8_t value) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | where); @@ -54,7 +54,7 @@ void pci_mmio_write_config8(pci_devfn_t dev, unsigned int where, u8 value) } static __always_inline -void pci_mmio_write_config16(pci_devfn_t dev, unsigned int where, u16 value) +void pci_mmio_write_config16(pci_devfn_t dev, uint16_t where, uint16_t value) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | (where & ~1)); @@ -62,7 +62,7 @@ void pci_mmio_write_config16(pci_devfn_t dev, unsigned int where, u16 value) } static __always_inline -void pci_mmio_write_config32(pci_devfn_t dev, unsigned int where, u32 value) +void pci_mmio_write_config32(pci_devfn_t dev, uint16_t where, uint32_t value) { void *addr; addr = (void *)(uintptr_t)(CONFIG_MMCONF_BASE_ADDRESS | dev | (where & ~3)); @@ -77,37 +77,37 @@ void pci_mmio_write_config32(pci_devfn_t dev, unsigned int where, u32 value) */ static __always_inline -uint8_t pci_s_read_config8(pci_devfn_t dev, unsigned int where) +uint8_t pci_s_read_config8(pci_devfn_t dev, uint16_t where) { return pci_mmio_read_config8(dev, where); } static __always_inline -uint16_t pci_s_read_config16(pci_devfn_t dev, unsigned int where) +uint16_t pci_s_read_config16(pci_devfn_t dev, uint16_t where) { return pci_mmio_read_config16(dev, where); } static __always_inline -uint32_t pci_s_read_config32(pci_devfn_t dev, unsigned int where) +uint32_t pci_s_read_config32(pci_devfn_t dev, uint16_t where) { return pci_mmio_read_config32(dev, where); } static __always_inline -void pci_s_write_config8(pci_devfn_t dev, unsigned int where, uint8_t value) +void pci_s_write_config8(pci_devfn_t dev, uint16_t where, uint8_t value) { pci_mmio_write_config8(dev, where, value); } static __always_inline -void pci_s_write_config16(pci_devfn_t dev, unsigned int where, uint16_t value) +void pci_s_write_config16(pci_devfn_t dev, uint16_t where, uint16_t value) { pci_mmio_write_config16(dev, where, value); } static __always_inline -void pci_s_write_config32(pci_devfn_t dev, unsigned int where, uint32_t value) +void pci_s_write_config32(pci_devfn_t dev, uint16_t where, uint32_t value) { pci_mmio_write_config32(dev, where, value); } -- cgit v1.2.3