From 43cf27d3a7d90e07099396d2ff8af2c1435669ee Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 27 Oct 2021 18:31:16 +0200 Subject: include/device/pci_ids,soc/amd/common/block/lpc: drop duplicate PCI IDs PCI_DEVICE_ID_AMD_FAM17H_LPC and PCI_DEVICE_ID_AMD_FAM17H_SMBUS redefine the same values that are already defined by PCI_DEVICE_ID_AMD_CZ_LPC and PCI_DEVICE_ID_AMD_CZ_SMBUS, so drop PCI_DEVICE_ID_AMD_FAM17H_LPC and PCI_DEVICE_ID_AMD_FAM17H_SMBUS. Also add some comments to the places in the code where the defines are used to clarify which ID is used on which hardware generation. Signed-off-by: Felix Held Change-Id: Id0b3d7b5a886ccc76d82ada6be4145e85fd51ede Reviewed-on: https://review.coreboot.org/c/coreboot/+/58696 Tested-by: build bot (Jenkins) Reviewed-by: Jason Glenesk Reviewed-by: Raul Rangel --- src/include/device/pci_ids.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/include/device/pci_ids.h') diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 0e4da41921..1ed6ac9eda 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -620,8 +620,6 @@ #define PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_RAID_VER0 0x7916 #define PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_RAID_VER1 0x7917 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_SD 0x7906 -#define PCI_DEVICE_ID_AMD_FAM17H_SMBUS 0x790B -#define PCI_DEVICE_ID_AMD_FAM17H_LPC 0x790E #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_GBE 0x1458 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_GBE 0x1641 #define PCI_DEVICE_ID_AMD_FAM17H_I2S_AC97 0x1644 -- cgit v1.2.3