From b8c473e32feb4cd36e6a6b8f7023efb591bba42c Mon Sep 17 00:00:00 2001 From: Zheng Bao Date: Tue, 9 Jun 2020 09:30:39 +0800 Subject: amd/00730F01: Clean the Microcode updating According to the comments of https://review.coreboot.org/c/coreboot/+/41719 , which is about Microcode patch for amd/picasso. Change the code with the same way. The changes include: 1. combine the microcode_xxx.c and update_microcode.c into one source. 2. Redefine the microcode updating function to eliminate the parameter. Get the revision ID in the black box. Reduce the depth of function calls. 3. Get the revision ID by bitwise calculation instead of lookup table. 4. Reduce the confusing type casts. 5. Squash some lines. We do not change the way it used to be. The code assume only one microcode is integrated in CBFS. If needed in future, 41719 is the example of integrating multiple binaries. And, 41719 depends on the definition in this patch. Change-Id: I8b0da99db0d3189058f75e199f05492c4e6c5881 Signed-off-by: Zheng Bao Signed-off-by: Zheng Bao Reviewed-on: https://review.coreboot.org/c/coreboot/+/42094 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/include/cpu/amd/microcode.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/include/cpu') diff --git a/src/include/cpu/amd/microcode.h b/src/include/cpu/amd/microcode.h index 29b5576a7f..800661b797 100644 --- a/src/include/cpu/amd/microcode.h +++ b/src/include/cpu/amd/microcode.h @@ -1,7 +1,6 @@ #ifndef CPU_AMD_MICROCODE_H #define CPU_AMD_MICROCODE_H -void update_microcode(u32 cpu_deviceid); -void amd_update_microcode_from_cbfs(u16 equivalent_processor_rev_id); +void amd_update_microcode_from_cbfs(void); #endif /* CPU_AMD_MICROCODE_H */ -- cgit v1.2.3