From b456a96361fd8f170b2c6ff17a8ce23c787e0d7c Mon Sep 17 00:00:00 2001 From: Caveh Jalali Date: Wed, 2 Nov 2022 03:29:32 -0700 Subject: ec/google/chromeec: Fix keyboard_backlight call The EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT command does not return data, so don't specify a result buffer. BUG=b:258126464 BRANCH=none TEST=none Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7 Signed-off-by: Caveh Jalali Reviewed-on: https://review.coreboot.org/c/coreboot/+/69368 Tested-by: build bot (Jenkins) Reviewed-by: Daisuke Nojiri --- src/ec/google/chromeec/ec.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/ec') diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 1fa5906995..b609559f7a 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -77,20 +77,19 @@ int google_chromeec_kbbacklight(int percent) struct ec_params_pwm_set_keyboard_backlight params = { .percent = percent % 101, }; - struct ec_response_pwm_get_keyboard_backlight resp = {}; struct chromeec_command cmd = { .cmd_code = EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT, .cmd_version = 0, .cmd_data_in = ¶ms, - .cmd_data_out = &resp, + .cmd_data_out = NULL, .cmd_size_in = sizeof(params), - .cmd_size_out = sizeof(resp), + .cmd_size_out = 0, .cmd_dev_index = 0, }; google_chromeec_command(&cmd); - printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: %x status (%x)\n", - resp.percent, cmd.cmd_code); + printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: status (%x)\n", + cmd.cmd_code); return cmd.cmd_code; } -- cgit v1.2.3