From 2285b72d0684f958ab372948d17f2da89db456c7 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 16 Feb 2023 08:21:15 +0000 Subject: Revert "ec/starlabs/merlin: Add support for enabling the mirror flag" This reverts commit b42ca4d0b2fafe7214396d30a1a833ac33cf85bc. Reason for revert: The mirror flag "0x01" is mirror once, which relies on the EC remembering that it's been mirrored. However, the EC forgets this if it's been without power for 20 minutes or so. Even if power is connected then, it'll instantly try to mirror and it can't charge whilst doing it. It can either result in incomplete EC firmware, or a loop where it's constantly trying to mirror. Change-Id: I79da9143cc63459e7e29431eff2cb14200424b37 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/72678 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/ec/starlabs/merlin/Kconfig | 7 ------- 1 file changed, 7 deletions(-) (limited to 'src/ec/starlabs/merlin/Kconfig') diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig index 203fd4884b..6ccd21791c 100644 --- a/src/ec/starlabs/merlin/Kconfig +++ b/src/ec/starlabs/merlin/Kconfig @@ -64,13 +64,6 @@ config EC_STARLABS_MAX_CHARGE help Select if the mainboard supports limiting the maximum charge of the battery. -config EC_STARLABS_MIRROR_FLAG - bool - default n - depends on EC_STARLABS_ITE - help - Select if the EC should mirror the EC firmware contained in the coreboot ROM. - config EC_STARLABS_MERLIN bool "Use open-source Merlin EC Firmware" default n -- cgit v1.2.3