From ca4b587f95c0f1ed64e187511781abdfd4c7ebfb Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 26 Dec 2022 08:17:06 +0100 Subject: {superio,ec}/acpi: Replace constant "One" with actual number Change-Id: I5c77b6d1e1dc1134f62dcb3e93df01dc9c2f386c Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/71520 Reviewed-by: Elyes Haouas Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/ec/purism/librem-ec/acpi/ac.asl | 2 +- src/ec/purism/librem-ec/acpi/battery.asl | 6 +++--- src/ec/purism/librem-ec/acpi/ec.asl | 2 +- src/ec/purism/librem-ec/acpi/hid.asl | 6 +++--- src/ec/purism/librem-ec/acpi/librem-ec.asl | 2 +- src/ec/purism/librem-ec/acpi/lid.asl | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) (limited to 'src/ec/purism/librem-ec') diff --git a/src/ec/purism/librem-ec/acpi/ac.asl b/src/ec/purism/librem-ec/acpi/ac.asl index 7326676198..b417e03c53 100644 --- a/src/ec/purism/librem-ec/acpi/ac.asl +++ b/src/ec/purism/librem-ec/acpi/ac.asl @@ -8,7 +8,7 @@ Device (AC) _SB }) - Name (ACFG, One) + Name (ACFG, 1) Method (_PSR, 0, NotSerialized) // _PSR: Power Source { diff --git a/src/ec/purism/librem-ec/acpi/battery.asl b/src/ec/purism/librem-ec/acpi/battery.asl index 9dc401c795..0266c2a75d 100644 --- a/src/ec/purism/librem-ec/acpi/battery.asl +++ b/src/ec/purism/librem-ec/acpi/battery.asl @@ -32,10 +32,10 @@ Device (BAT0) Name (PBIF, Package (0x0D) { - One, // 0 - Power Unit + 1, // 0 - Power Unit 0xFFFFFFFF, // 1 - Design Capacity 0xFFFFFFFF, // 2 - Last Full Charge Capacity - One, // 3 - Battery Technology + 1, // 3 - Battery Technology BATTERY_DESIGN_VOLTAGE_MV, // 4 - Design Voltage Zero, // 5 - Design Capacity of Warning Zero, // 6 - Design Capacity of Low @@ -129,7 +129,7 @@ Device (BAT0) } Else { - Local0 |= One + Local0 |= 1 Local1 = (^^PCI0.LPCB.EC0.BPR0 & 0xFFFF) } diff --git a/src/ec/purism/librem-ec/acpi/ec.asl b/src/ec/purism/librem-ec/acpi/ec.asl index 4e7b4a1f15..bceb23c92d 100644 --- a/src/ec/purism/librem-ec/acpi/ec.asl +++ b/src/ec/purism/librem-ec/acpi/ec.asl @@ -35,7 +35,7 @@ Device (\_SB.PCI0.LPCB.EC0) Method (_REG, 2, Serialized) // _REG: Region Availability { Printf ("EC: _REG %o %o", ToHexString(Arg0), ToHexString(Arg1)) - If ((Arg0 == 0x03) && (Arg1 == One)) { + If ((Arg0 == 0x03) && (Arg1 == 1)) { // Enable hardware touchpad lock, airplane mode, and keyboard backlight keys ECOS = 1 diff --git a/src/ec/purism/librem-ec/acpi/hid.asl b/src/ec/purism/librem-ec/acpi/hid.asl index 6610c2e1bc..8bbb65bc45 100644 --- a/src/ec/purism/librem-ec/acpi/hid.asl +++ b/src/ec/purism/librem-ec/acpi/hid.asl @@ -25,7 +25,7 @@ Device (HIDD) Method (HPEM, 1, Serialized) { - HBSY = One + HBSY = 1 HIDX = Arg0 Notify (HIDD, 0xC0) @@ -36,11 +36,11 @@ Device (HIDD) Local0++ } - If (HBSY == One) + If (HBSY == 1) { HBSY = Zero HIDX = Zero - Return (One) + Return (1) } Else { diff --git a/src/ec/purism/librem-ec/acpi/librem-ec.asl b/src/ec/purism/librem-ec/acpi/librem-ec.asl index ea227c74be..5f1e53d666 100644 --- a/src/ec/purism/librem-ec/acpi/librem-ec.asl +++ b/src/ec/purism/librem-ec/acpi/librem-ec.asl @@ -110,7 +110,7 @@ Device (LIEC) { Method (GKBL, 0, Serialized) { Local0 = 0 If (^^PCI0.LPCB.EC0.ECOK) { - ^^PCI0.LPCB.EC0.FDAT = One + ^^PCI0.LPCB.EC0.FDAT = 1 ^^PCI0.LPCB.EC0.FCMD = 0xCA Local0 = ^^PCI0.LPCB.EC0.FBUF ^^PCI0.LPCB.EC0.FCMD = Zero diff --git a/src/ec/purism/librem-ec/acpi/lid.asl b/src/ec/purism/librem-ec/acpi/lid.asl index 723dd6dd98..0a643416e3 100644 --- a/src/ec/purism/librem-ec/acpi/lid.asl +++ b/src/ec/purism/librem-ec/acpi/lid.asl @@ -10,7 +10,7 @@ Device (LID0) If (^^PCI0.LPCB.EC0.ECOK) { Return (^^PCI0.LPCB.EC0.LSTE) } Else { - Return (One) + Return (1) } } -- cgit v1.2.3