From bfb11bec3b3fec638adf864a9b9b2cff6671fed8 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Tue, 30 Jan 2024 09:53:46 +0900 Subject: include/device/device.h: Remove CHIP_NAME() macro Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin Reviewed-by: Felix Singer Reviewed-by: Jakub Czapiga Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/ec/kontron/it8516e/ec.c | 2 +- src/ec/kontron/kempld/kempld.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/ec/kontron') diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c index 5288976dd2..1d6780885f 100644 --- a/src/ec/kontron/it8516e/ec.c +++ b/src/ec/kontron/it8516e/ec.c @@ -239,6 +239,6 @@ static void it8516e_enable(struct device *dev) } const struct chip_operations ec_kontron_it8516e_ops = { - CHIP_NAME("Kontron (Fintec/ITE) IT8516E EC") + .name = "Kontron (Fintec/ITE) IT8516E EC", .enable_dev = it8516e_enable }; diff --git a/src/ec/kontron/kempld/kempld.c b/src/ec/kontron/kempld/kempld.c index 9527429e0e..7050ff4900 100644 --- a/src/ec/kontron/kempld/kempld.c +++ b/src/ec/kontron/kempld/kempld.c @@ -105,6 +105,6 @@ static void kempld_enable_dev(struct device *const dev) } struct chip_operations ec_kontron_kempld_ops = { - CHIP_NAME("Kontron KEMPLD") + .name = "Kontron KEMPLD", .enable_dev = kempld_enable_dev, }; -- cgit v1.2.3