From a461b694a6c0468cd679628aeebf83437027fb45 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 5 Apr 2020 13:55:12 +0200 Subject: Drop unnecessary DEVICE_NOOP entries Providing an explicit no-op function pointer is only necessary for `.read_resources` and `.set_resources`. All other device-operation pointers are optional and can be NULL. Change-Id: I3d139f7be86180558cabec04b8566873062e33be Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/40206 Reviewed-by: Paul Menzel Reviewed-by: Angel Pons Reviewed-by: Edward O'Callaghan Reviewed-by: HAOUAS Elyes Tested-by: build bot (Jenkins) --- src/ec/google/chromeec/ec_lpc.c | 1 - src/ec/google/wilco/chip.c | 1 - 2 files changed, 2 deletions(-) (limited to 'src/ec/google') diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index dd78922d00..c34082c56b 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -438,7 +438,6 @@ static void lpc_ec_read_resources(struct device *dev) static struct device_operations ops = { .init = lpc_ec_init, .read_resources = lpc_ec_read_resources, - .enable_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = google_chromeec_acpi_name, diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c index 2ce9bf0ad4..f4bea48be4 100644 --- a/src/ec/google/wilco/chip.c +++ b/src/ec/google/wilco/chip.c @@ -219,7 +219,6 @@ static const char *wilco_ec_acpi_name(const struct device *dev) static struct device_operations ops = { .init = wilco_ec_init, .read_resources = wilco_ec_read_resources, - .enable_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, .acpi_fill_ssdt = wilco_ec_fill_ssdt_generator, .acpi_name = wilco_ec_acpi_name, -- cgit v1.2.3