From 2177ccfac9a85f3ef431884a4a59b136c34cb5cd Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Fri, 2 Feb 2018 10:08:22 -0800 Subject: ec/google/chromeec: Remove wake flag from keyboard IRQ The keyboard IRQ was changed to ExclusiveAndWake in order to support waking from suspend-to-idle (S0ix) with commit f611fcfacac5be14a51e04ae4d0b1e25cd5439c0 http://review.coreboot.org/11712 However this is triggering a kernel panic on Windows 10 because it apparently does not like legacy device interrupts to to be set as wake capable. This change is no longer necessary because the linux kernel was changed to always treat the keyboard as wake capable: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/input/serio/i8042.c?id=f13b2065de8147a1652b830ea5db961cf80c09df Change-Id: I26e27de68095f8d176108f39312338522d7cfba0 Signed-off-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/23563 Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/ec/google/chromeec/acpi/superio.asl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/ec/google/chromeec/acpi') diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index 0f06e30cb3..7cd65239a7 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -151,7 +151,7 @@ Device (SIO) { #ifdef SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ #else - IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} + IRQ (Edge, ActiveHigh, Exclusive) {1} #endif }) @@ -163,7 +163,7 @@ Device (SIO) { #ifdef SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ #else - IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} + IRQ (Edge, ActiveHigh, Exclusive) {1} #endif } EndDependentFn () -- cgit v1.2.3