From f89cd1cf43b4afbd78dbf14ad71bfba92a28029f Mon Sep 17 00:00:00 2001 From: Johnny Lin Date: Tue, 12 Apr 2022 15:46:43 +0800 Subject: drivers/ocp/ewl: Enforce MRC when there's EWL type3 error If Fastboot is enabled, the next boot will skip MRC and won't be able to detect MRC error via EWL and still continues booting. Enforce FSP MRC training in the next boot. Change-Id: I9dee0472f8e2602cecf88c6d00dec0bf02b9f7bd Signed-off-by: Johnny Lin Reviewed-on: https://review.coreboot.org/c/coreboot/+/69148 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Lean Sheng Tan --- src/drivers/ocp/ewl/ewl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/drivers') diff --git a/src/drivers/ocp/ewl/ewl.c b/src/drivers/ocp/ewl/ewl.c index 244634bcf9..f1f8137b26 100644 --- a/src/drivers/ocp/ewl/ewl.c +++ b/src/drivers/ocp/ewl/ewl.c @@ -87,6 +87,10 @@ void get_ewl(void) } offset += warning_header->Size; } - if (type3_flag) + if (type3_flag) { + /* If Fastboot is enabled, the next boot will skip MRC and won't detect + MRC error via EWL and still can boot up, so enforce MRC after reboot. */ + soc_set_mrc_cold_boot_flag(true); die("Memory Training Error!\n"); + } } -- cgit v1.2.3