From f43132e20cb746376b316185e9800a98ea4ffa20 Mon Sep 17 00:00:00 2001 From: Benjamin Doron Date: Sun, 9 Apr 2023 19:58:05 +0000 Subject: drivers/efi: Fix linker error when SMM phase uses option API For security reasons, removing the efivars implementation of the option API was considered. However, this use-case is not the "None" option-backend (CONFIG_OPTION_BACKEND_NONE), so the SMM phase also does not use the no-op in option.h. This causes linker errors when the option API is called. For example, src/soc/intel/common/block/pmc/pmclib.c and src/console/init.c use `get_uint_option`. Minimising code in SMM can be implemented as a follow-up. Change-Id: Ief3b52965d8fde141c12266a716f254dd45559d5 Signed-off-by: Benjamin Doron Reviewed-on: https://review.coreboot.org/c/coreboot/+/73905 Tested-by: build bot (Jenkins) Reviewed-by: Lean Sheng Tan --- src/drivers/efi/Makefile.inc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/drivers') diff --git a/src/drivers/efi/Makefile.inc b/src/drivers/efi/Makefile.inc index e2251b2c2b..2597c09bff 100644 --- a/src/drivers/efi/Makefile.inc +++ b/src/drivers/efi/Makefile.inc @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only all-$(CONFIG_DRIVERS_EFI_VARIABLE_STORE) += efivars.c +smm-$(CONFIG_DRIVERS_EFI_VARIABLE_STORE) += efivars.c all-$(CONFIG_USE_UEFI_VARIABLE_STORE) += option.c +smm-$(CONFIG_USE_UEFI_VARIABLE_STORE) += option.c -- cgit v1.2.3