From edf459fe65f9166a06899b2ed86a517ffe8bfdd9 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 28 Aug 2017 17:20:49 -0700 Subject: acpigen: Add stop gpio control to power resource There is at least one I2C device (being used by Soraka) that has 3 controls -- enable, reset and stop. If the stop gpio is not put into the right state when turning off the device in suspend mode, then it causes leakage. Thus, we need control in power resource to be able to stop the device when entering suspend state. BUG=b:64987428 TEST=Verified on soraka that touchscreen stop is correctly configured on suspend. Change-Id: Iae5ec7eb3972c5c7f80956d60d0d3c321bbefb0f Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/21249 Reviewed-by: Duncan Laurie Tested-by: build bot (Jenkins) --- src/drivers/i2c/generic/chip.h | 4 ++++ src/drivers/i2c/generic/generic.c | 3 ++- src/drivers/spi/acpi/acpi.c | 3 ++- src/drivers/spi/acpi/chip.h | 5 +++++ 4 files changed, 13 insertions(+), 2 deletions(-) (limited to 'src/drivers') diff --git a/src/drivers/i2c/generic/chip.h b/src/drivers/i2c/generic/chip.h index 8b285f054c..037a8004bc 100644 --- a/src/drivers/i2c/generic/chip.h +++ b/src/drivers/i2c/generic/chip.h @@ -61,6 +61,10 @@ struct drivers_i2c_generic_config { struct acpi_gpio enable_gpio; /* Delay to be inserted after device is enabled. */ unsigned enable_delay_ms; + /* GPIO used to stop operation of device. */ + struct acpi_gpio stop_gpio; + /* Delay to be inserted after disabling stop. */ + unsigned stop_delay_ms; /* Generic properties for exporting device-specific data to the OS */ struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST]; diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index fa27b0e9fd..460f01514b 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -145,7 +145,8 @@ void i2c_generic_fill_ssdt(struct device *dev, if (config->has_power_resource) acpi_device_add_power_res( &config->reset_gpio, config->reset_delay_ms, - &config->enable_gpio, config->enable_delay_ms); + &config->enable_gpio, config->enable_delay_ms, + &config->stop_gpio, config->stop_delay_ms); /* Callback if any. */ if (callback) diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 102780f65d..2a39814c3d 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -168,7 +168,8 @@ static void spi_acpi_fill_ssdt_generator(struct device *dev) if (config->has_power_resource) acpi_device_add_power_res( &config->reset_gpio, config->reset_delay_ms, - &config->enable_gpio, config->enable_delay_ms); + &config->enable_gpio, config->enable_delay_ms, + &config->stop_gpio, config->stop_delay_ms); acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ diff --git a/src/drivers/spi/acpi/chip.h b/src/drivers/spi/acpi/chip.h index 6b54100536..35341d33be 100644 --- a/src/drivers/spi/acpi/chip.h +++ b/src/drivers/spi/acpi/chip.h @@ -47,6 +47,11 @@ struct drivers_spi_acpi_config { struct acpi_gpio enable_gpio; /* Delay to be inserted after device is enabled. */ unsigned enable_delay_ms; + + /* GPIO used to stop operation of device. */ + struct acpi_gpio stop_gpio; + /* Delay to be inserted after disabling stop. */ + unsigned stop_delay_ms; }; #endif /* __SPI_ACPI_CHIP_H__ */ -- cgit v1.2.3