From dac1a456f9d04483fd2c5fb79b7a5092cbb366eb Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Tue, 2 Mar 2021 10:54:52 +0100 Subject: src/drivers/i2c/rx6110sa: Add official ACPI ID In commit 2609eaaa8f (src/drivers/i2c/rx6110sa: Omit _HID temporarily) the randomly assigned and therefore wrong ACPI ID for RTC RX6110SA was removed. In the meantime Seiko-Epson did a great job and registered an official vendor ID in the ACPI database [1]. Further on, Seiko-Epson has now assigned the unique Product Identifier for the RX6110SA, which is '6110'. The assignment of the Product Identifier is controlled by the vendor and there is no official database where this ID is stored in. It is up to the vendor to make sure that this ID stays unique. This patch adds this new vendor and product ID to the driver. Together with a pending Linux patch this RTC is now useable as ACPI device in Linux. [1] https://uefi.org/ACPI_ID_List?search=SECC Change-Id: I45838162f014a760520692c6dcaae329ad98547d Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/coreboot/+/51176 Reviewed-by: Andy Shevchenko Reviewed-by: Johannes Hahn Reviewed-by: Mario Scheithauer Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/drivers/i2c/rx6110sa/rx6110sa.c | 1 + src/drivers/i2c/rx6110sa/rx6110sa.h | 1 + 2 files changed, 2 insertions(+) (limited to 'src/drivers') diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index 210444ebc4..2b8b9b28f0 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -198,6 +198,7 @@ static void rx6110sa_fill_ssdt(const struct device *dev) /* Device */ acpigen_write_scope(scope); acpigen_write_device(acpi_device_name(dev)); + acpigen_write_name_string("_HID", RX6110SA_HID_NAME); acpigen_write_name_string("_DDN", RX6110SA_HID_DESC); acpigen_write_STA(acpi_device_status(dev)); diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h index fc0109db2a..5be6be7382 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.h +++ b/src/drivers/i2c/rx6110sa/rx6110sa.h @@ -4,6 +4,7 @@ #define _I2C_RX6110SA_H_ #define RX6110SA_ACPI_NAME "ERX6" +#define RX6110SA_HID_NAME "SECC6110" #define RX6110SA_HID_DESC "Real Time Clock" /* Register layout */ -- cgit v1.2.3