From b4ad5d0a93e60e887bcda9819597954e72115272 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Sun, 22 Feb 2015 16:13:57 +0100 Subject: drivers/xgi: Avoid double-free xgifb_probe() doesn't own the object it tries to free in its error code path, potentially leading to a double-free in xgi_z9s_init(). Since we don't actually implement free, it doesn't matter too much, but let's keep things proper. Change-Id: I70c8f395fd59584664040ca6e07be56e046c80fc Signed-off-by: Patrick Georgi Found-by: Coverity Scan Reviewed-on: http://review.coreboot.org/8506 Reviewed-by: Timothy Pearson Reviewed-by: Paul Menzel Reviewed-by: Alexandru Gagniuc Tested-by: build bot (Jenkins) --- src/drivers/xgi/common/xgi_coreboot.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/drivers') diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c index 361bd628e4..324a0fa981 100644 --- a/src/drivers/xgi/common/xgi_coreboot.c +++ b/src/drivers/xgi/common/xgi_coreboot.c @@ -333,7 +333,6 @@ int xgifb_probe(struct pci_dev *pdev, struct xgifb_video_info *xgifb_info) error_1: error_disable: - free(xgifb_info); return ret; } -- cgit v1.2.3