From 8c9a89de9961e7029835e987cb0f705b7efa77a7 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sun, 6 Jun 2021 08:14:57 +0300 Subject: arch/x86/ioapic: Drop irq_on_fsb as a configurable item MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APIC Serial Bus pins were removed with ICH5 already, so a choice 'irq_on_fsb = 0' would not take effect. The related register BOOT_CONFIG 0x3 is also not documented since ICH5. For emulation/qemu-q35 with ICH9 the choice INTERRUPT_ON_APIC_BUS was wrong and ignored as BOOT_CONFIG register emulation was never implemented. For ICH4 and earlier, the choice to use FSB can be made based on the installed CPU model but this is now just hardwired to match P4 CPUs of aopen/dxplplusu. For sb/intel/i82371eb register BOOT_CONFIG 0x3 is also not defined and the only possible operation mode there is APIC Serial Bus, which requires no configuration. Change-Id: Id433e0e67cb83b44a3041250481f307b2ed1ad18 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/55257 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/drivers/generic/ioapic/chip.h | 1 - src/drivers/generic/ioapic/ioapic.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'src/drivers') diff --git a/src/drivers/generic/ioapic/chip.h b/src/drivers/generic/ioapic/chip.h index 88720bbc87..9a9395f714 100644 --- a/src/drivers/generic/ioapic/chip.h +++ b/src/drivers/generic/ioapic/chip.h @@ -6,7 +6,6 @@ typedef struct drivers_generic_ioapic_config { u32 version; u8 apicid; - u8 irq_on_fsb; u8 enable_virtual_wire; u8 have_isa_interrupts; void *base; diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c index 708d9a1a7e..4a8bcf8177 100644 --- a/src/drivers/generic/ioapic/ioapic.c +++ b/src/drivers/generic/ioapic/ioapic.c @@ -13,8 +13,7 @@ static void ioapic_init(struct device *dev) if (!dev->enabled || !config) return; - setup_ioapic_helper(config->base, config->apicid, config->irq_on_fsb, - config->enable_virtual_wire); + setup_ioapic_helper(config->base, config->apicid, config->enable_virtual_wire); } static void ioapic_read_resources(struct device *dev) -- cgit v1.2.3