From 24681f188ac868c0bc9b3f1fc55732f0ec6a08fe Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Sun, 10 Jun 2018 13:33:44 -0700 Subject: drivers/i2c/generic: Ensure config is not NULL before accessing it This change checks to ensure that config is not NULL before it is accessed for the first time. Reported by: Coverity CID #1393312 Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/27009 Tested-by: build bot (Jenkins) Reviewed-by: Naresh Solanki --- src/drivers/i2c/generic/generic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/drivers') diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 7f1ce16fea..1b12df57d3 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -202,6 +202,9 @@ static void i2c_generic_enable(struct device *dev) { struct drivers_i2c_generic_config *config = dev->chip_info; + if (!config) + return; + /* Check if device is present by reading GPIO */ if (config->device_present_gpio) { int present = gpio_get(config->device_present_gpio); @@ -219,9 +222,8 @@ static void i2c_generic_enable(struct device *dev) dev->ops = &i2c_generic_ops; /* Name the device as per description provided in devicetree */ - if (config && config->desc) { + if (config->desc) dev->name = config->desc; - } } struct chip_operations drivers_i2c_generic_ops = { -- cgit v1.2.3