From d09a8819883e3d6784a359e7f25358f4012af24b Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Thu, 17 Dec 2015 13:03:11 -0800 Subject: drivers/xgi/common: Fix XGI_SetGroup2 This code looks like it was created from a disassembly of some other driver. Attempt to fix it, without hardware or documentation. CID 142909: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) Change-Id: I9b9cadf2acdba73913aad6bbe0d14ad64a652915 Signed-off-by: Stefan Reinauer Reviewed-on: https://review.coreboot.org/12774 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Tested-by: Raptor Engineering Automated Test Stand Reviewed-by: Martin Roth Reviewed-by: Alexandru Gagniuc Reviewed-by: Timothy Pearson --- src/drivers/xgi/common/vb_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/drivers/xgi/common') diff --git a/src/drivers/xgi/common/vb_setmode.c b/src/drivers/xgi/common/vb_setmode.c index 91e4929ef0..0143076a44 100644 --- a/src/drivers/xgi/common/vb_setmode.c +++ b/src/drivers/xgi/common/vb_setmode.c @@ -3616,7 +3616,7 @@ static void XGI_SetGroup2(unsigned short ModeNo, unsigned short ModeIdIndex, | (tempax & 0x00FF)); temp = (tempax & 0xFF00) >> 8; } else { - temp = (tempax & 0x00FF) >> 8; + temp = (tempax & 0x00FF); } xgifb_reg_set(pVBInfo->Part2Port, 0x44, temp); -- cgit v1.2.3