From 6e3d42ab4269ca6c82db9a129bff2429c42f5aeb Mon Sep 17 00:00:00 2001 From: Eric Lai Date: Mon, 14 Mar 2022 17:00:39 +0800 Subject: drivers/wifi/generic: Fix is_cnvi function dev->ops = &wifi_cnvi_ops need is_cnvi be true. This cause the exclusive statement so is_cnvi never be true in !DEVTREE_EARLY. BUG=b:224317408 TEST=no assertion in coreboot. [EMERG] ASSERTION ERROR: file 'src/acpi/acpigen_pci.c', line 24 Signed-off-by: Eric Lai Change-Id: I1ca6312ce164c43021686b483f6579164614cede Reviewed-on: https://review.coreboot.org/c/coreboot/+/62784 Tested-by: build bot (Jenkins) Reviewed-by: Kangheui Won Reviewed-by: Tim Wawrzynczak --- src/drivers/wifi/generic/generic.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/drivers/wifi') diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index a6936f1d11..5aaedaeafe 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -43,11 +43,7 @@ struct device_operations wifi_cnvi_ops = { static bool is_cnvi(const struct device *dev) { -#if !DEVTREE_EARLY - return dev && dev->ops == &wifi_cnvi_ops; -#else return dev && dev->path.type != DEVICE_PATH_PCI; -#endif } bool wifi_generic_cnvi_ddr_rfim_enabled(const struct device *dev) -- cgit v1.2.3