From ea1e36694d67f0db613839f5a5a4c336d1711a13 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Mon, 24 Oct 2022 13:58:30 +0200 Subject: coreboot_tables: Drop uart PCI addr Only edk2 used this to fill in a different struct but even there the entries go unused, so removing this struct element from coreboot has no side effects. Change-Id: Iadd2678c4e01d30471eac43017392d256adda341 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/68767 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Hung-Te Lin Reviewed-by: Bill XIE Reviewed-by: Lean Sheng Tan --- src/drivers/uart/Kconfig | 11 ----------- src/drivers/uart/pl011.c | 1 - src/drivers/uart/uart8250io.c | 1 - src/drivers/uart/uart8250mem.c | 1 - 4 files changed, 14 deletions(-) (limited to 'src/drivers/uart') diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig index beba4012e2..a2a7f9f59b 100644 --- a/src/drivers/uart/Kconfig +++ b/src/drivers/uart/Kconfig @@ -75,14 +75,3 @@ config UART_USE_REFCLK_AS_INPUT_CLOCK default n help Use uart_platform_refclk to specify the input clock value. - -config UART_PCI_ADDR - hex "UART's PCI bus, device, function address" - default 0x0 - help - Specify zero if the UART is connected to another bus type. - For PCI based UARTs, build the value as: - * 1 << 31 - Valid bit, PCI UART in use - * Bus << 20 - * Device << 15 - * Function << 12 diff --git a/src/drivers/uart/pl011.c b/src/drivers/uart/pl011.c index 0a73d829ad..3653262700 100644 --- a/src/drivers/uart/pl011.c +++ b/src/drivers/uart/pl011.c @@ -43,7 +43,6 @@ void uart_fill_lb(void *data) serial.baud = get_uart_baudrate(); serial.regwidth = 1; serial.input_hertz = uart_platform_refclk(); - serial.uart_pci_addr = CONFIG_UART_PCI_ADDR; lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index aa8c969530..79df37ce93 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -114,7 +114,6 @@ void uart_fill_lb(void *data) serial.baud = get_uart_baudrate(); serial.regwidth = 1; serial.input_hertz = uart_platform_refclk(); - serial.uart_pci_addr = CONFIG_UART_PCI_ADDR; lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250, data); diff --git a/src/drivers/uart/uart8250mem.c b/src/drivers/uart/uart8250mem.c index 1834095014..79e786bf12 100644 --- a/src/drivers/uart/uart8250mem.c +++ b/src/drivers/uart/uart8250mem.c @@ -146,7 +146,6 @@ void uart_fill_lb(void *data) else serial.regwidth = sizeof(uint8_t); serial.input_hertz = uart_platform_refclk(); - serial.uart_pci_addr = CONFIG_UART_PCI_ADDR; lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); -- cgit v1.2.3