From 23b0053586974e0db70349a272d8cc09167fb4cb Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Wed, 10 Oct 2012 14:21:23 -0700 Subject: SPI: Fix and enable Fast Read support - Fix handling of 5-byte Fast Read command in the ICH SPI driver. This fix is ported from the U-boot driver. - Allow CONFIG_SPI_FLASH_NO_FAST_READ to be overridden by defining a name for the bool in Kconfig and removing the forced select in southbridge config - Fix use of CONFIG_SPI_FLASH_NO_FAST_READ in SPI drivers to use #if instead of #ifdef - Relocate flash functions in SMM so they are usable. This really only needs to happen for read function pointer since it uses a global function rather than a static one from the chip, but it is good to ensure the rest are set up correctly as well. Change-Id: Ic1bb0764cb111f96dd8a389d83b39fe8f5e72fbd Signed-off-by: Duncan Laurie Reviewed-on: http://review.coreboot.org/1775 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/drivers/spi/macronix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/drivers/spi/macronix.c') diff --git a/src/drivers/spi/macronix.c b/src/drivers/spi/macronix.c index 148527d953..f9138e1e55 100644 --- a/src/drivers/spi/macronix.c +++ b/src/drivers/spi/macronix.c @@ -210,7 +210,7 @@ struct spi_flash *spi_flash_probe_macronix(struct spi_slave *spi, u8 *idcode) mcx->flash.write = macronix_write; mcx->flash.erase = macronix_erase; -#ifdef CONFIG_SPI_FLASH_NO_FAST_READ +#if CONFIG_SPI_FLASH_NO_FAST_READ mcx->flash.read = spi_flash_cmd_read_slow; #else mcx->flash.read = spi_flash_cmd_read_fast; -- cgit v1.2.3