From 08c76e1f7d08ec9ef6481c725dc26fba4441e766 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sun, 25 Aug 2019 13:05:46 +0300 Subject: devicetree: Fix improper use of chip_operations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Auto-discoverable PCI devices do not require field .enable_dev of chip_operations to be set. They are matched with PCI drivers by the use of PCI vendor and device ID fields. The name given for the chip_operations struct must match the pathname the way it is present in the devicetree.cb files. If there was no match, util/sconfig would currently choose to use the empty weak declaration it creates in static.c file. Change-Id: I684a087a1f8ee4e1a5fd83450cd371fcfdbb6847 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/35096 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson --- src/drivers/ricoh/rce822/rce822.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/drivers/ricoh') diff --git a/src/drivers/ricoh/rce822/rce822.c b/src/drivers/ricoh/rce822/rce822.c index 72862f5174..485bdd05b9 100644 --- a/src/drivers/ricoh/rce822/rce822.c +++ b/src/drivers/ricoh/rce822/rce822.c @@ -71,3 +71,7 @@ static const struct pci_driver rce822 __pci_driver = { .vendor = PCI_VENDOR_ID_RICOH, .devices = pci_device_ids, }; + +struct chip_operations drivers_ricoh_rce822_ops = { + CHIP_NAME("RICOH RCE822") +}; -- cgit v1.2.3