From 88512b00ad2786795889a71b7835efe1cffba458 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 17 Aug 2023 15:44:52 +0000 Subject: {driver, soc/intel/cmn/cse}: Refactor ISH FW Version implementation This patch uses the CSE firmware specific data to store Intel ISH firmware related information. Sending an ISH partition version information command on every boot cycle would impact the overall boot performance. This information is used by the auto-test framework to ensure the ISH firmware update is proper for in-field devices. BUG=b:285405031 TEST=Able to build and boot google/rex. Verified ISH FW version is getting displayed across warm resets without impacting the boot time. Change-Id: I0242c26dd90d834815799f54740d8147ff9d45b7 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/77176 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/drivers/intel/ish/ish.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/drivers/intel') diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index a84be5b120..d1b85f570e 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -50,15 +50,15 @@ static void intel_ish_enable(struct device *dev) static void intel_ish_get_version(void) { - struct cse_fw_partition_info *version = cbmem_find(CBMEM_ID_CSE_PARTITION_VERSION); - if (version == NULL) + struct cse_specific_info *info = cbmem_find(CBMEM_ID_CSE_INFO); + if (info == NULL) return; printk(BIOS_DEBUG, "ISH version: %d.%d.%d.%d\n", - version->ish_partition_info.cur_ish_fw_version.major, - version->ish_partition_info.cur_ish_fw_version.minor, - version->ish_partition_info.cur_ish_fw_version.hotfix, - version->ish_partition_info.cur_ish_fw_version.build); + info->cse_fwp_version.ish_partition_info.cur_ish_fw_version.major, + info->cse_fwp_version.ish_partition_info.cur_ish_fw_version.minor, + info->cse_fwp_version.ish_partition_info.cur_ish_fw_version.hotfix, + info->cse_fwp_version.ish_partition_info.cur_ish_fw_version.build); } static void intel_ish_final(struct device *dev) -- cgit v1.2.3