From 61fcb7e9654634cfe0c8a7bf56581fb54d943bd8 Mon Sep 17 00:00:00 2001 From: Jakub Czapiga Date: Fri, 19 Feb 2021 11:44:22 +0100 Subject: acpi/acpigen.h: Add more intuitive AML package closing functions Until now every AML package had to be closed using acpigen_pop_len(). This commit introduces set of package closing functions corresponding with their opening function names. For example acpigen_write_if() opens if-statement package, acpigen_write_if_end() closes it. Now acpigen_write_else() closes previously opened acpigen_write_if(), so acpigen_pop_len() is not required before it. Signed-off-by: Jakub Czapiga Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd Reviewed-on: https://review.coreboot.org/c/coreboot/+/50910 Tested-by: build bot (Jenkins) Reviewed-by: Lance Zhao Reviewed-by: Angel Pons --- src/drivers/intel/usb4/retimer/retimer.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/drivers/intel') diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 4e56d641f8..fad353bebe 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -77,7 +77,6 @@ static void usb4_retimer_cb_set_power_state(void *arg) */ acpigen_write_if_lequal_op_int(LOCAL0_OP, 0); acpigen_disable_tx_gpio(power_gpio); - acpigen_pop_len(); /* If */ /* * Else { -- cgit v1.2.3