From b0cbb2cd174a55098135f3419c50ad2a8f72a1eb Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Tue, 17 Jun 2014 15:04:36 +1000 Subject: drivers/intel/gma: Uninitialized var before if condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The variable 'wait' is used uninitialized whenever 'if' condition is false if (val & DDI_BUF_CTL_ENABLE) { ^~~~~~~~~~~~~~~~~~~~~~~~ Leading to an uninitialized use occurs here: if (wait) ^~~~ Change-Id: I7d96bf1e33b9c4312d4a0ba8276e83d17d6cd070 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/6052 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Kyösti Mälkki --- src/drivers/intel/gma/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/drivers/intel/gma/intel_ddi.c') diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 9ddd781c97..f28e943ed5 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -123,7 +123,7 @@ static void intel_wait_ddi_buf_idle(int port) void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp, int port) { - int wait; + int wait = 0; uint32_t val; if (io_i915_read32(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) { -- cgit v1.2.3