From 5d09d48050db8cd25d49a52141cd8b956f36e6f7 Mon Sep 17 00:00:00 2001 From: Ryan Salsamendi Date: Tue, 4 Jul 2017 13:53:00 -0700 Subject: drivers/intel/gma: Fix undefined behavior Fix undefined behavior found by clang's -Wshift-sign-overflow, find, and source inspection. Left shifting an int where the right operand is >= the width of the type is undefined. Add UL suffix since it's safe for unsigned types. Change-Id: I5240a19647c8ad59f64925f3e1c199446a886d2d Signed-off-by: Ryan Salsamendi Reviewed-on: https://review.coreboot.org/20466 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/drivers/intel/gma/intel_bios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/drivers/intel/gma/intel_bios.h') diff --git a/src/drivers/intel/gma/intel_bios.h b/src/drivers/intel/gma/intel_bios.h index 000d7d5d8f..2e1211b9d1 100644 --- a/src/drivers/intel/gma/intel_bios.h +++ b/src/drivers/intel/gma/intel_bios.h @@ -584,7 +584,7 @@ struct bdb_edp { #define SWF11_DPMS_STANDBY (1<<0) #define SWF11_DPMS_ON 0 -#define SWF14_GFX_PFIT_EN (1<<31) +#define SWF14_GFX_PFIT_EN (1UL<<31) #define SWF14_TEXT_PFIT_EN (1<<30) #define SWF14_LID_STATUS_CLOSED (1<<29) /* 0 here means open */ #define SWF14_POPUP_EN (1<<28) -- cgit v1.2.3