From bdb5c8feaed4cf914b474deeb30686e327ee9228 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 16 May 2017 21:39:50 -0500 Subject: coreboot_tables: specify clear interface for lb_framebuffer() For some reason the "interface" for adding framebuffer information is sitting in src/include/vbe.h while also guarding the call to fill_lb_framebuffer() with vbe_mode_info_valid() along with some macro if CONFIG_* for good measure. Move the fill_lb_framebuffer() declaration to coreboot_tables.h and provide a comment about how it should be used. Also, now that there's no need for the notion of a global vbe_mode_info_valid() remove it from the conditional call path of fill_lb_framebuffer(). Change-Id: Ib3ade6314624091ae70424664527a02b279d0c9b Signed-off-by: Aaron Durbin Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/19729 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/drivers/intel/gma/gma.ads | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/drivers/intel/gma/gma.ads') diff --git a/src/drivers/intel/gma/gma.ads b/src/drivers/intel/gma/gma.ads index d912df1635..157ec89fcc 100644 --- a/src/drivers/intel/gma/gma.ads +++ b/src/drivers/intel/gma/gma.ads @@ -15,9 +15,6 @@ is ---------------------------------------------------------------------------- - function vbe_mode_info_valid return Interfaces.C.int; - pragma Export (C, vbe_mode_info_valid, "vbe_mode_info_valid"); - type lb_framebuffer is record tag : word32; size : word32; @@ -37,7 +34,9 @@ is reserved_mask_size : word8; end record; - procedure fill_lb_framebuffer (framebuffer : out lb_framebuffer); + function fill_lb_framebuffer + (framebuffer : in out lb_framebuffer) + return Interfaces.C.int; pragma Export (C, fill_lb_framebuffer, "fill_lb_framebuffer"); end GMA; -- cgit v1.2.3