From 6838aaebf9ec836a13d57bd85bc0e7e396834e8b Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sun, 29 Jul 2018 10:53:01 +0200 Subject: drvs/intel/gma/acpi: Add methods to use MBOX3 * Add Mailbox 3 driver * Request brightness change through Mailbox 3 * Return Ones on error or if unsupported * Mark existing code as legacy (still required if no GMA driver is running) * Call legacy code if Mailbox 3 is unsupported, on error or if gma driver isn't running Tested on Lenovo T430: * Brightness control still works * Brightness is the same on S3 resume Change-Id: I51554c819148336b204d28972cbf775a10c3fb8a Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/27711 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Nathaniel Roach Reviewed-by: Nicola Corna Reviewed-by: Felix Held --- src/drivers/intel/gma/acpi/pch.asl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/drivers/intel/gma/acpi/pch.asl') diff --git a/src/drivers/intel/gma/acpi/pch.asl b/src/drivers/intel/gma/acpi/pch.asl index 31911965cd..b7bb324b60 100644 --- a/src/drivers/intel/gma/acpi/pch.asl +++ b/src/drivers/intel/gma/acpi/pch.asl @@ -22,7 +22,11 @@ Device (GFX0) Field (GFXC, DWordAcc, NoLock, Preserve) { Offset (0x10), - BAR0, 64 + BAR0, 64, + Offset (0xe4), + ASLE, 32, + Offset (0xfc), + ASLS, 32, } OperationRegion (GFRG, SystemMemory, And (BAR0, 0xfffffffffffffff0), 0x400000) -- cgit v1.2.3