From c4ea8f7d3fb56b43482b8abd8405280f50d98864 Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Mon, 23 May 2016 12:16:58 -0700 Subject: drivers/intel/fsp2_0: Send post codes around calls to the blobs By design, FSP will send POST codes to port 80. In this case we have both coreboot and FSP pushing post codes, which may make debugging harder. In order to get a clear picture of where FSP execution begins and ends, send post codes before and after any call to the FSP blobs. Note that sending a post code both before and after is mostly useful on chromeec enabled boards, where the EC console will provide a historic list of post codes. Change-Id: Icfd22b4f6d9e91b01138f97efd711d9204028eb1 Signed-off-by: Alexandru Gagniuc Reviewed-on: https://review.coreboot.org/14951 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Paul Menzel --- src/drivers/intel/fsp2_0/notify.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'src/drivers/intel/fsp2_0/notify.c') diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c index d9de02235e..bd489d4ce6 100644 --- a/src/drivers/intel/fsp2_0/notify.c +++ b/src/drivers/intel/fsp2_0/notify.c @@ -38,17 +38,23 @@ enum fsp_status fsp_notify(enum fsp_notify_phase phase) printk(BIOS_DEBUG, "FspNotify %x\n", (uint32_t) phase); - if (phase == AFTER_PCI_ENUM) + if (phase == AFTER_PCI_ENUM) { timestamp_add_now(TS_FSP_BEFORE_ENUMERATE); - else if (phase == READY_TO_BOOT) + post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); + } else if (phase == READY_TO_BOOT) { timestamp_add_now(TS_FSP_BEFORE_FINALIZE); + post_code(POST_FSP_NOTIFY_BEFORE_FINALIZE); + } ret = fspnotify(¬ify_params); - if (phase == AFTER_PCI_ENUM) + if (phase == AFTER_PCI_ENUM) { timestamp_add_now(TS_FSP_AFTER_ENUMERATE); - else if (phase == READY_TO_BOOT) + post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); + } else if (phase == READY_TO_BOOT) { timestamp_add_now(TS_FSP_AFTER_FINALIZE); + post_code(POST_FSP_NOTIFY_BEFORE_FINALIZE); + } return ret; } -- cgit v1.2.3