From de01136484c58d13457ccf1e42fdb2310f3cbe65 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Thu, 17 Nov 2016 22:39:29 +0200 Subject: intel post-car: Increase stacktop alignment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Align top of stack to 8 bytes, value documented as FSP1.1 requirement. Also fix some cases of uintptr_t casted to unsigned long. Change-Id: I5bbd100eeb673417da205a2c2c3410fef1af61f0 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/17461 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- src/drivers/intel/fsp1_1/stack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/drivers/intel/fsp1_1') diff --git a/src/drivers/intel/fsp1_1/stack.c b/src/drivers/intel/fsp1_1/stack.c index 6a64921a1a..059f8ba4f1 100644 --- a/src/drivers/intel/fsp1_1/stack.c +++ b/src/drivers/intel/fsp1_1/stack.c @@ -35,14 +35,12 @@ void *setup_stack_and_mtrrs(void) uint32_t max_mtrrs; uint32_t num_mtrrs; uint32_t *slot; - unsigned long top_of_stack; /* Display the MTTRs */ soc_display_mtrrs(); /* Top of stack needs to be aligned to a 8-byte boundary. */ - top_of_stack = romstage_ram_stack_top(); - slot = (void *)top_of_stack; + slot = (void *)romstage_ram_stack_top(); num_mtrrs = 0; max_mtrrs = soc_get_variable_mtrr_count(NULL); -- cgit v1.2.3