From d3a73280cc8e01a28cbdb1a4d086e4dda7b35f0c Mon Sep 17 00:00:00 2001 From: John Zhao Date: Fri, 31 May 2019 09:58:49 -0700 Subject: src/drivers/intel: Avoid NULL pointer dereference Coverity detects pointer fih as FORWARD_NULL. Add sanity check for fih to prevent NULL pointer dereference. BUG=CID 1401717 TEST=Built and boot up to kernel. Change-Id: Ia6853e5302c87d9ffe52b942f067be56f6e77406 Signed-off-by: John Zhao Reviewed-on: https://review.coreboot.org/c/coreboot/+/33150 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Christian Walter --- src/drivers/intel/fsp1_1/car.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/drivers/intel/fsp1_1/car.c') diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 10f9524650..dd17664036 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -120,6 +120,9 @@ void mainboard_romstage_entry(unsigned long bist) * the flash is memory mapped CPU's address space. */ FSP_INFO_HEADER *fih = find_fsp((uintptr_t)rdev_mmap_full(prog_rdev(&fsp))); + if (!fih) + die("Invalid FSP header\n"); + cache_as_ram_stage_main(fih); } -- cgit v1.2.3