From bfb11bec3b3fec638adf864a9b9b2cff6671fed8 Mon Sep 17 00:00:00 2001
From: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Date: Tue, 30 Jan 2024 09:53:46 +0900
Subject: include/device/device.h: Remove CHIP_NAME() macro

Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:

CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,

This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.

It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.

Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
---
 src/drivers/i2c/nct7802y/nct7802y.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/drivers/i2c/nct7802y/nct7802y.c')

diff --git a/src/drivers/i2c/nct7802y/nct7802y.c b/src/drivers/i2c/nct7802y/nct7802y.c
index bb52a3fd0b..f313ef7f10 100644
--- a/src/drivers/i2c/nct7802y/nct7802y.c
+++ b/src/drivers/i2c/nct7802y/nct7802y.c
@@ -45,6 +45,6 @@ static void nct7802y_enable(struct device *const dev)
 }
 
 struct chip_operations drivers_i2c_nct7802y_ops = {
-	CHIP_NAME("NCT7802Y")
+	.name = "NCT7802Y",
 	.enable_dev = nct7802y_enable
 };
-- 
cgit v1.2.3