From 245b688a282a4b13d317b153c426096d7c614049 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 26 Jun 2024 10:40:43 +0200 Subject: device/azalia_device.c: Use `azalia_enter_reset()` Use the existing `azalia_enter_reset()` function instead of explicitly clearing the bit (and having to explain in a comment what this means). Change-Id: I04924e68420a93a1ad46f5a7ab359e38c0f7e210 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/83217 Reviewed-by: Felix Singer Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/device/azalia_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/device') diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 8051f2e7ee..02bbf8944f 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -96,8 +96,7 @@ static u16 codec_detect(u8 *base) no_codec: /* Codec Not found */ - /* Put HDA back in reset (BAR + 0x8) [0] */ - azalia_set_bits(base + HDA_GCTL_REG, 1, 0); + azalia_enter_reset(base); printk(BIOS_DEBUG, "azalia_audio: no codec!\n"); return 0; } -- cgit v1.2.3