From a173a6255b5c3b7febea5cdf581fc3a57299954a Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Tue, 17 Jun 2014 17:05:36 +1000 Subject: Remove guarding #includes by CONFIG_FOO combinations First of many to remove guarding the inclusion of headers based on CONFIG_ options. This *potentially* could hide issues such as functions being swapped from under our feet, since different runtime behaviour could be declared with the function same name and type-signature. Hence, depending on the header we happen to get may change runtime behaviour. Change-Id: Ife56801c783c44e1882abef711e09b85b7f295a4 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/6055 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/device/oprom/yabel/io.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'src/device/oprom/yabel/io.c') diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index 94f610debd..37beccbe4e 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -20,15 +20,12 @@ #include #include "io.h" -#if CONFIG_PCI_OPTION_ROM_RUN_YABEL #include #include #include -#endif -#if CONFIG_ARCH_X86 #include -#else + // these are not used, only needed for linking, must be overridden using X86emu_setupPioFuncs // with the functions and struct below void @@ -76,10 +73,6 @@ inl(u16 port) return 0; } -#ifndef CONFIG_PCI -#endif -#endif - #if CONFIG_YABEL_DIRECTHW u8 my_inb(X86EMU_pioAddr addr) { -- cgit v1.2.3