From 31cef1f46e5caa63794709c381a68ac1a9394bbb Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sat, 8 Nov 2014 09:35:31 +1100 Subject: device/dram/ddr3.c: Fix sizeof on array func param overflow The sizeof on array function parameter will return size of 'u8 *' instead of 'spd_raw_data' (aka 'u8 [256]' leading to an overflow. Found-by: Clang Change-Id: I78e113a640b2953c853eb43bd6874e4694260b1f Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/7353 Tested-by: build bot (Jenkins) Reviewed-by: Vladimir Serbinenko --- src/device/dram/ddr3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/device/dram') diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index a43caed5ab..00f2ba9009 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -127,7 +127,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd) } dimm->dram_type = SPD_MEMORY_TYPE_SDRAM_DDR3; - crc = spd_ddr3_calc_crc(spd, sizeof(spd)); + crc = spd_ddr3_calc_crc(spd, sizeof(*spd)); /* Compare with the CRC in the SPD */ spd_crc = (spd[127] << 8) + spd[126]; /* Verify the CRC is correct */ -- cgit v1.2.3