From fa9f107319c00563d2da4cda03ddba179c904135 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Thu, 1 Mar 2018 16:37:06 -0800 Subject: cpu/x86/mp_init: Increase AP check-in time-out to 1second Currently, the AP check-in time-out in bsp_do_flight_plan is set to 100ms. However, as the number of APs increases, contention could increase especially for resource like UART. This led to MP record time-out issues on KBL platform with 7 APs and serial-console enabled BIOS image. This change increases the time-out value to 1 second to be on the safer side and let APs check-in before continuing boot. BUG=b:74085891 TEST=Verified that MP record time-out is not observed anymore on Nami. Change-Id: I979c11a10e6888aef0f71b5632ea803a67bbb0ff Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/24965 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin --- src/cpu/x86/mp_init.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/cpu') diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 92eb722eb4..23aea14683 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -539,7 +539,12 @@ static int bsp_do_flight_plan(struct mp_params *mp_params) { int i; int ret = 0; - const int timeout_us = 100000; + /* + * Set time-out to wait for APs to a huge value (=1 second) since it + * could take a longer time for APs to check-in as the number of APs + * increases (contention for resources like UART also increases). + */ + const int timeout_us = 1000000; const int step_us = 100; int num_aps = mp_params->num_cpus - 1; -- cgit v1.2.3